Skip to content

Revert "Config: remove version id from response body"#863

Merged
Prajna1999 merged 1 commit into
mainfrom
revert-822-enhancement/config_remove_vid
May 19, 2026
Merged

Revert "Config: remove version id from response body"#863
Prajna1999 merged 1 commit into
mainfrom
revert-822-enhancement/config_remove_vid

Conversation

@Prajna1999
Copy link
Copy Markdown
Collaborator

@Prajna1999 Prajna1999 commented May 19, 2026 •
edited by coderabbitai Bot
Loading

Reverts #822.

Changes

Summary by CodeRabbit

  • New Features
    • Configuration version responses now explicitly include the unique identifier field. The version ID is now part of the public data structure returned by configuration version endpoints, making the identifier accessible in all API operations related to configuration version management and data exports.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 19, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 03cfe26f-b228-46b8-a98f-61adfacfed88

📥 Commits

Reviewing files that changed from the base of the PR and between 68369a8 and cea362c.

📒 Files selected for processing (1)
  • backend/app/models/config/version.py
📝 Walkthrough

Walkthrough

The ConfigVersionPublic model in backend/app/models/config/version.py is updated to include an explicit id: UUID field with a description, making the configuration version identifier part of the public/serialized response schema.

Changes

ConfigVersionPublic Schema Update

Layer / File(s) Summary
Add id field to ConfigVersionPublic
backend/app/models/config/version.py		 ConfigVersionPublic now declares an id: UUID field with description, explicitly exposing the configuration version identifier in the public data contract.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • Ayush8923
  • vprashrex

Poem

🐰 A config version needs its name,
An id to stake its rightful claim,
UUID field joins the public sight,
Schema grows both clear and bright,
Hopping forward with delight! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: reverting a prior commit that removed the version id from the response body, which directly corresponds to adding the id field back to ConfigVersionPublic.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-822-enhancement/config_remove_vid

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Prajna1999 Prajna1999 self-assigned this May 19, 2026
@Prajna1999 Prajna1999 added the bug Something isn't working label May 19, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Prajna1999 Prajna1999 removed this from Kaapi-dev May 19, 2026
@Prajna1999 Prajna1999 merged commit 7a22c28 into main May 19, 2026
3 checks passed
@Prajna1999 Prajna1999 deleted the revert-822-enhancement/config_remove_vid branch May 19, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkhileshNegi AkhileshNegi AkhileshNegi approved these changes

@Ayush8923 Ayush8923 Ayush8923 approved these changes

Assignees

@Prajna1999 Prajna1999

Labels

bug Something isn't working ready-for-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Prajna1999 @AkhileshNegi @Ayush8923